Workspace runner: execute independent verification before review #5
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feat/workspace-verification"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Workspace runner: execute independent verification (
verification-v1)The runner half of console PR z3k-tech/console#29. After
project-rebaseandproject-reviewhave prepared fresh detached checkouts, and before any reviewer agent starts, the runner now executes the project's member-approved verification commands and reports what it observed.What changes
project-verify(new): asks the console for the commands bound to the current snapshot, refuses to run if the console's snapshot hash differs fromdelivery-snapshot.jsonin the review checkouts, starts a run, executes each command withsh -cfrom that repository's checkout root, and submits exit code, duration, output SHA-256, the last 4000 characters and the log name. The submit call uses the run's one-shotjsv_…token only; the agent token is never sent there and is stripped from the command environment along withCONSOLE_URL.card-runner:passedorskippedcontinues to the reviewer as before.failedmoves the card back toreadywith no reviewer started; the console has already commented the failing output on the card for the builder's next launch.blockedor a run that could not start moves the card towaitingfor a person.timeout; commands not yet started are reportedtimeouttoo. Exit 126/127 is reported asblocked, never as a failure of the change.Verification
WORKSPACE_TEST_SCRIPTS=$PWD python3 -B workspace/test_delivery_loops.py: 29 tests pass, including three new ones with an in-memory console: observed exit codes and tails are posted with the run token only and the agent credential is absent from the command environment; a deadline kills a slow command and marks it and the resttimeout; not-enabled, already-passed, snapshot-mismatch and out-of-checkout repositories never start a run. The image build runs this suite before publishing.Limits
Commands run inside the Studio pod with its filesystem and network; this is not a hostile-process sandbox, and workspace Git credentials remain reachable to a command that looks for them. Logs are kept under the review directory's
verification/folder and are not uploaded. The runner must not print secrets into command output, since tails are stored as sent.